Remove obsolete lattice-preview GUI - #111
Draft
skilledwolf wants to merge 1 commit into
Draft
Conversation
skilledwolf
force-pushed
the
WIP/remove-lattice-preview
branch
from
July 24, 2026 16:36
ea69cc0 to
1f3922b
Compare
skilledwolf
changed the base branch from
master
to
modernization/pyalps-nanobind-wheel
July 24, 2026 16:36
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lattice-previewGUIWhy
The feature was introduced in 2009 and last updated in 2016. Its launcher still relies on Python 2 syntax and contains broken environment-variable names (
BUILDIDRandPHTHONPATH), while the GUI uses legacy wxPython APIs and has no dependency detection for wxPython or VTK. Ordinary non-wheel builds install it even when those runtime dependencies are unavailable.Removing the feature as a unit is safer than retaining or modernizing its otherwise-unused
tool/license.pyhelper.Scope
The removal is self-contained: it deletes only the obsolete GUI, its private helpers, its build and installation rules, and its packaging-manifest entry.
Validation
lattice-previewor helper-module referencesgit diff --checkThe commit includes
[skip ci]; these removal-only changes were validated locally without starting CI.