Add regression tests for LidarLocalization ICP and BasicSim kinematics - #33
Draft
cursor[bot] wants to merge 2 commits into
Draft
Add regression tests for LidarLocalization ICP and BasicSim kinematics#33cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Cover scan-to-map seeding/guards/translation/yaw recovery, bicycle ego integration order, NPC steer slew, and State BB corner geometry. Co-authored-by: Majid Khonji <majid-khonji@users.noreply.github.com>
Collinear wall scans left translation/yaw underconstrained; seeded Gaussian landmarks make ICP recovery deterministic and unique. Co-authored-by: Majid Khonji <majid-khonji@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds focused regression coverage for high-risk paths that remained untested on
dev, while avoiding duplication of open drafts #17/#20/#22–#32.Risky behavior now covered
LidarLocalizationICP: first scan seeds the reference map without mutating ego;reset()clears map/pose; pure translation and yaw recovery on a seeded asymmetric cloud; None/empty/<3-point/3D z-band-empty scans are no-opsBasicSimbicycle ego kinematics: XY integrates with pre-update velocity, then accel updatesv, then yaw uses post-updatevwith default axle length 2.5BasicSimNPC plant: withnpc_control=True, agents advance and steer is slew-limited to|Δsteer| ≤ 3·dt; withnpc_control=False, agents stay frozen while ego movesState.get_bb_corners: axis-aligned corners and 90° yaw length/width swap used by LiDAR raycasting and collision geometryTest files added/updated
test/c10_perception/test_c16_lidar_localization.py(new)test/c40_execution/test_c46_basic_sim_kinematics.py(new)test/c10_perception/test_c11_state_geometry.py(new)Why these tests materially reduce regression risk
LidarLocalization is the only non-GT localization path and silently writes ego pose from scan alignment—wrong ICP/guards corrupt the whole stack state estimate. BasicSim bicycle/NPC integration is the plant for Control Step/Steer and multi-agent sims; integration-order or steer-slew regressions change every closed-loop demo. Bounding-box corners feed LiDAR hits and corridor collision; wrong rotation quietly shifts perceived obstacles.
Validation
All 14 tests passed. No production code changes.