Skip to content
This repository was archived by the owner on Apr 19, 2026. It is now read-only.

fix: fix viem usage - #7

Merged
coffee-the-dev merged 3 commits into
mainfrom
feat/erc-1271
Mar 25, 2026
Merged

fix: fix viem usage#7
coffee-the-dev merged 3 commits into
mainfrom
feat/erc-1271

Conversation

@coffee-the-dev

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Mar 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mpp-abstract-mpp-demo Ready Ready Preview, Comment Mar 25, 2026 10:43pm

Request Review

@cursor

cursor Bot commented Mar 25, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Touches on-chain signing, contract reads/writes, and typed-data verification by switching to viem client methods and removing explicit chain: null overrides, which could affect transaction submission or chain selection if any callers relied on the old behavior.

Overview
Updates the MPP client/server integration to use viem's instance methods (e.g. publicClient.readContract, walletClient.writeContract, client.verifyTypedData, walletClient.signTypedData) instead of importing helpers from viem/actions.

Removes explicit chain: null overrides from contract write calls in charge/session flows, relying on the configured client chain instead, and adds a patch changeset (fix: clean up viem usage).

Written by Cursor Bugbot for commit 5b7247c. This will update automatically on new commits. Configure here.

@changeset-bot

changeset-bot Bot commented Mar 25, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5b7247c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@abstract-foundation/mpp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coffee-the-dev coffee-the-dev changed the title fix: remove null chain fix: fix viem usage Mar 25, 2026
@coffee-the-dev
coffee-the-dev merged commit e825a63 into main Mar 25, 2026
6 checks passed
@coffee-the-dev
coffee-the-dev deleted the feat/erc-1271 branch March 25, 2026 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant