Updating package maker to create packages safely - #2177
Open
vanridal wants to merge 4 commits into
Open
Conversation
vanridal
commented
Aug 3, 2026
Contributor
- package_maker would not create .building prefix when build payload
- changed to use pre_variant_install from repository to get build_prefix
- Variant is installed now after make_base and make_root calls
- using get_package_payload_path to generate base path
- Note: the variant passed to make_base and make_root is now a memory repo variant
- package_maker would not create .building prefix when build payload - changed to use pre_variant_install from repository to get build_prefix - Variant is installed now after make_base and make_root calls - using get_package_payload_path to generate base path Signed-off-by: george.ridal <george.ridal@findesign.com.au>
Signed-off-by: george.ridal <george.ridal@findesign.com.au>
Signed-off-by: george.ridal <george.ridal@findesign.com.au>
Signed-off-by: george.ridal <george.ridal@findesign.com.au>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2177 +/- ##
==========================================
+ Coverage 61.29% 61.32% +0.03%
==========================================
Files 164 164
Lines 20568 20573 +5
Branches 3575 3576 +1
==========================================
+ Hits 12607 12617 +10
+ Misses 7089 7086 -3
+ Partials 872 870 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.