Skip to content

Updating package maker to create packages safely - #2177

Open
vanridal wants to merge 4 commits into
AcademySoftwareFoundation:mainfrom
vanridal:#2145-package_maker-should-build-payload-before-install
Open

Updating package maker to create packages safely#2177
vanridal wants to merge 4 commits into
AcademySoftwareFoundation:mainfrom
vanridal:#2145-package_maker-should-build-payload-before-install

Conversation

@vanridal

@vanridal vanridal commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
  • package_maker would not create .building prefix when build payload
  • changed to use pre_variant_install from repository to get build_prefix
  • Variant is installed now after make_base and make_root calls
  • using get_package_payload_path to generate base path
  • Note: the variant passed to make_base and make_root is now a memory repo variant

- package_maker would not create .building prefix when build payload
- changed to use pre_variant_install from repository to get build_prefix
- Variant is installed now after make_base and make_root calls
- using get_package_payload_path to generate base path

Signed-off-by: george.ridal <george.ridal@findesign.com.au>
@vanridal
vanridal requested a review from a team as a code owner August 3, 2026 05:22
Signed-off-by: george.ridal <george.ridal@findesign.com.au>
Signed-off-by: george.ridal <george.ridal@findesign.com.au>
Signed-off-by: george.ridal <george.ridal@findesign.com.au>
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.32%. Comparing base (a4160c2) to head (9f7014e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2177      +/-   ##
==========================================
+ Coverage   61.29%   61.32%   +0.03%     
==========================================
  Files         164      164              
  Lines       20568    20573       +5     
  Branches     3575     3576       +1     
==========================================
+ Hits        12607    12617      +10     
+ Misses       7089     7086       -3     
+ Partials      872      870       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant