Skip to content

Upgrading Luxon to v3 #463

Description

@EliezerB123

Any chance you've given any thought to upgrading Luxon to v2.5 or v3.0? (Or even v3.4)

There's a migration guide here, if it helps: https://moment.github.io/luxon/#upgrading

The reason I say that is because luxon added support for ESM-style imports in v2.5, which will get rid of these errors:

node_modules\ngx-material-timepicker\fesm2015\ngx-material-timepicker.js depends on 'luxon'. CommonJS or AMD dependencies can cause optimization bailouts.

For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

image

I understand this is a not insignificant migration, but if you're looking at it, that would be nice.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions