[8.2-stable] Fix not searchable parent pages - #79
Merged
Merged
Conversation
The index could also contain elements that are had hidden or not searchable parent elements. To avoid this the searchable? method has to travers the element tree up and test if all parents are visible and searchable. The new method "parent_elements_searchable?" is only testing for searchable and public? of the parent element. This avoids the look up to the page and page_version, because these objects are the same for all parent_elements. (cherry picked from commit 27f4f19)
The searchable? method for elements is including page, page_version, and the parent elements. The include statement improve the rebuilding performance. (cherry picked from commit 15ef9c3)
tvdeyen
approved these changes
May 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.2-stable:Questions ?
Please refer to the Backport tool documentation