[PWGCF] Fixes in femto framework - #16938
Conversation
ariedel-cern
commented
Jul 6, 2026
ariedel-cern
commented
- Fix minor bugs in V0 and cascade selection
- Fix namespace across the full framework
- Implement first batch of warnings indicated by the new clang-tidy check
|
O2 linter results: ❌ 0 errors, |
[PWGCF] Please consider the following formatting changes to AliceO2Group#16938
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @ariedel-cern.
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
| (o2::aod::femtocollisions::magField >= o2::framework::expressions::as<int8_t>(selection.magFieldMin) && \ | ||
| o2::aod::femtocollisions::magField <= o2::framework::expressions::as<int8_t>(selection.magFieldMax)) && \ | ||
| ncheckbit(o2::aod::femtocollisions::mask, selection.collisionMask) | ||
| // NOLINTNEXTLINE(cppcoreguidelines-macro-usage) |
There was a problem hiding this comment.
Why did you disable the check?
There was a problem hiding this comment.
Hi Vit, I found that using macros is a convenient way to reuse the same partitions and filters across different files. Without suppressing the check, clang-tidy warns that the macro should be replaced with a constexpr template function. I am not sure that is actually possible in this case (I tried a few approaches, but I couldn't get the code to compile). If you know of a way to implement this without macros, please let me know, and I will replace them with functions.
There was a problem hiding this comment.
Hi Anton, indeed. In your case, it probably makes sense. Thanks for the clarification.
3 participants
