Antalya 26.6: Cache vended catalog credentials - #2153
Closed
zvonand wants to merge 2 commits into
Closed
Conversation
…next commit) --- Original cherry-pick message follows: Merge pull request #1923 from Altinity/fix/antalya-26.3/iceberg-creds Antalya 26.3: Cache vended catalog credentials # Conflicts: # docs/en/engines/database-engines/datalake.md # src/Common/ProfileEvents.cpp # src/Databases/DataLake/DatabaseDataLake.cpp # src/Databases/DataLake/RestCatalog.cpp # src/Databases/DataLake/RestCatalog.h # src/Databases/DataLake/StorageCredentials.h
Kept only the source PR's own additions; dropped "theirs"-side context that belongs to other PRs and is absent on antalya-26.6 (`namespaces` docs row, `object_storage_cluster` setting extern, `RestCatalog::AllowedNamespaces`, the REST/Glue/Unity catalog ProfileEvents block, and the older `std::optional<AccessToken> access_token` member). Adapted: placed the two new ProfileEvents rows (DataLakeRestCatalogCredentialsVended / ...CacheHits) at the end of APPLY_FOR_BUILTIN_EVENTS and declared them via a new `namespace ProfileEvents` block plus `#include <Common/ProfileEvents.h>` in RestCatalog.cpp — antalya-26.6 does not have the Iceberg catalog ProfileEvents instrumentation (PR #1868, commit 23a9f20) that the source PR extended Adapted: moved the setVendedCredentialsCacheTTL() call into antalya-26.6's lazy `DatabaseDataLake::getCatalog()` accessor (catalog construction now lives in `initialize()`), right before `return catalog_impl;` as in the source PR Adapted: implemented `isEmpty()` for `GCSCredentials`, a subclass added on antalya-26.6 after the source PR, which the PR's new pure-virtual `IStorageCredentials::isEmpty()` requires
zvonand
added
releasy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add caching for REST catalog vended credentials. Added a new setting
vended_credentials_cache_ttl: maximum cache entry lifetime (in seconds) for vended credentials (REST catalogs only). Default300;0disables caching (#1923 by @zvonand).CI/CD Options
Exclude tests:
Regression jobs to run:
Cherry-picked from #1923.