Harden PHPUnit suite and mount contracts - #2159
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--testsuiteselectors in one generated-PHP passFixes #2158. Follow-up hardening for #2153 and #2154.
Verification
npm run buildnpm exec -- tsx tests/phpunit-project-autoload.test.tsnpm run test:phpunit-structured-evidencenpm run test:phpunit-runtime-rejectionnpm exec -- tsx tests/playground-direct-mount-materialization.test.tsnpm exec -- tsx tests/staged-input-materialization.test.tsnpm exec -- tsx tests/mount-materialization.test.tsnpm exec -- tsx tests/recipe-runtime-setup-staged-materialization.test.tsnpm exec -- tsx tests/playground-readonly-mounts.test.tsnpm exec -- tsx tests/playground-readonly-mounts-integration.test.tsFull WPCOM TeamCity parity at comparator SHA
7ae9ae21ca30f7fc9724aecfb54a16f674f82a23:Reproduction: run
node scripts/run-wpcom-teamcity-parity.mjs --mode execute --allow-execute true --manifest artifacts/phpunit-profiles/teamcity-parity-manifest-7ae9ae21-corrected.json --concurrency 6 --shards 4 --timeout-multiplier 3from the WPCOM Codebox parity workspace with the certified runtime inputs.AI Assistance
OpenAI
gpt-5.6-solvia OpenCode identified the file-only suite edge case, consolidated generated-PHP option parsing, expanded executable integration coverage, and ran local and full WPCOM verification. Chris Huber remains responsible for the change.