Adding a new parameterless constructor to ExecutionRewoundEvent - #1383
Open
sophiatev wants to merge 1 commit into
Open
Adding a new parameterless constructor to ExecutionRewoundEvent#1383sophiatev wants to merge 1 commit into
ExecutionRewoundEvent#1383sophiatev wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a private parameterless constructor to ExecutionRewoundEvent to unblock JSON deserialization scenarios where constructor selection is ambiguous (aligning with existing patterns in other history event types).
Changes:
- Added a private parameterless constructor (
: base(-1)) toExecutionRewoundEventto support JSON deserialization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+42
to
+46
| // Private ctor for JSON deserialization (required by some storage providers and out-of-proc executors) | ||
| ExecutionRewoundEvent() | ||
| : base(-1) | ||
| { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new private parameterless constructor for the
ExecutionRewoundEventto enable JSON deserialization, otherwise it cannot choose between the two constructors with parameters