Adding the Manage Members Page

[brightfietsop-ux]

We have added the Manage Members page, which can be accessed through the Members card on the Department Portal.

WHAT'S WORKING:

• The names of supervisors are correctly pulled from the demo data.
• Supervisees are properly displayed (on the table, active means the student has approved their labor status form, and - pending means they have not done that yet).
• The Assign Coordinator switch works!
• The Ban/Unban Button also works!
• You can remove members by clicking on the trash icon to the right
• The Add Members dropdown/button technically works.
• The Ban/Unban button and the Remove Member button are displayed ONLY FOR ADMINS (as it is supposed to be).

WHAT'S NOT WORKING:

• we cannot directly access the page using the manage member button
• When supervisors are assigned as LC, they get assigned in every department.
• We cannot add department members who are not supervisors
• All staff members are supervisors

[BhushanSah]

I added tests for the new Manage Members helper logic.

The tests cover the smaller helper functions separately so the behavior is easier to verify and debug:

• supervisorsDbToDict

  • Checks that supervisor data is converted into the expected dictionary format.
  • Verifies that extra spaces are stripped from fields.
  • Confirms that the username is created correctly from the supervisor email.

• currentAcademicYear

  • Tests the academic year calculation before July.
  • Tests the academic year calculation starting in July.
  • I used monkeypatch so the test does not depend on the actual current date.

• attachPositionCounts

  • Tests that active/pending primary and secondary counts are added correctly when count data exists.
  • Tests that missing count data defaults to 0, so the Manage Members page does not break when a supervisor has no matching labor forms.

• getStudentCounts

  • Tests that active primary, pending primary, active secondary, and pending secondary positions are counted correctly.
  • Uses test department, supervisor, student, term, and labor status form records to verify the actual database query behavior.

• Released labor forms

  • Added a test to confirm that released labor forms are excluded from the active/pending position counts.
  • This is important because the Manage Members page should not count positions that have already been released.

I marked the database-dependent tests with @pytest.mark.integration, while the smaller pure helper tests were left as normal unit tests because they do not touch the database or Flask session.

All tests in tests/code/test_manageMembers.py are passing.

[conwelld]

I think the color of the pop-up that confirms a member's removal should change, because it is not consistent with the color used for warnings.

[MImran2002]

what you should do is remove this function totally in app>logic>getsupervisors.py there is a function call buildSupervisorDisplay that is technically what you are doing and that function is there but it is smaller go ahead and make changes to it so that it reflects what you want to but at the same time there is a route that uses the buildsupervisordisplay function so make the test for the logic and controller are not broken and are returning right