Fix stale characteristics under lazy execution when the index change - #290
Merged
Merged
Conversation
ha-my-bui
force-pushed
the
fix/stale-characteristics-lazy-execution
branch
3 times, most recently
from
August 4, 2026 19:16
7594823 to
ad53743
Compare
a-hartens
approved these changes
Aug 5, 2026
ha-my-bui
force-pushed
the
fix/stale-characteristics-lazy-execution
branch
from
August 5, 2026 19:42
0e6e41a to
215ceae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing lazy excecution bug : Under
lazy_execution=True, changing a cohort definition so the population shrinks (e.g. adding an inclusion) recomputes the index, but characteristic and outcome nodes still cache-hit: their fingerprint covers only their own definition, not the population they are computed against. Table1 then divides stale counts by the fresh N, producing percentages above 100%. The fix is as follows is to determine if the index stage has changed; if it did, clear the caches of characteristics and outcomes so they recompute against the new population.