Add region tld - #256
Open
SaltySnail wants to merge 7 commits into
Open
Conversation
WiserTixx
requested changes
Jun 24, 2026
WiserTixx
left a comment
WiserTixx
left a comment
Collaborator
There was a problem hiding this comment.
Does the cli argument overwrite the config file when both are specified? If so besides my comment it lgtm
Collaborator
Author
Yes CLI overwrites the config file (config file is loaded before CLI is handled) |
SaltySnail
force-pushed
the
add-region-tld
branch
from
June 25, 2026 16:33
55efae0 to
52e607c
Compare
WiserTixx
requested changes
Jun 25, 2026
WiserTixx
requested changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to specify a region in either the .cfg file, or as a startup argument (which take presedence).
By creating this pull request, I understand that code that is AI generated or otherwise automatically generated may be rejected without further discussion.
I declare that I fully understand all code I pushed into this PR, and wrote all this code myself and own the rights to this code.