feat(ui): link the User ID, Created By and Deleted By cells on Deleted Keys - #40750
Open
ryan-crabbe-berri wants to merge 2 commits into
Open
feat(ui): link the User ID, Created By and Deleted By cells on Deleted Keys#40750ryan-crabbe-berri wants to merge 2 commits into
ryan-crabbe-berri wants to merge 2 commits into
Conversation
…d Keys All three columns rendered as plain text, so auditing a deleted key meant copying an id into the Users page search box. Route them through IdentityCell with userDetailHref, which keeps the proxy admin placeholder unlinked. User Email and Team Alias stay as they are: the deleted key table has no column for either, so the API never populates them. Claude-Session: https://claude.ai/code/session_01NfwfQhamRNnSqgXMUjf3h4
Contributor
Greptile SummaryThis PR makes the User ID, Created By, and Deleted By values in the Deleted Keys table link to the corresponding user detail page
Confidence Score: 5/5The PR appears safe to merge, with the new links following existing dashboard routing and identity-cell contracts No actionable failures remain; identifiers are encoded, deployment path prefixes are preserved, the proxy-admin sentinel stays unlinked, and the changed behavior has meaningful tests
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/src/components/DeletedKeysPage/DeletedKeysTable/DeletedKeysTableColumns.tsx | Replaces three plain identity values with shared, mount-aware user links while preserving empty and proxy-admin fallback rendering |
| ui/litellm-dashboard/src/components/DeletedKeysPage/DeletedKeysTable/DeletedKeysTable.test.tsx | Adds focused assertions for all three user-detail links and verifies that the proxy-admin sentinel remains plain text |
Reviews (1): Last reviewed commit: "feat(ui): link the User ID, Created By a..." | Re-trigger Greptile
The page test renders the table, and the newly linked cells call useRouter, which throws without an App Router mounted. Matches how the other 35 test files in the suite stub next/navigation. Claude-Session: https://claude.ai/code/session_01NfwfQhamRNnSqgXMUjf3h4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
How it solves it:
userDetailHref, so the proxy admin placeholder stays unlinkedUser Flow
Before: an admin auditing a deleted key cannot get from the row to the people on it
After: the same admin clicks any of the three and lands on that user
default_user_idas plain text, because there is no user page for itRelevant issues
Linear ticket
Pre-Submission checklist
uv run pytest tests/test_litellm/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
Setup: proxy on :4021 and the dashboard dev server on :3021, both against the shared dev database. Created key
zzqa-links-deleted-keyowned byqa-links-userand deleted it with that user's key, so all three columns carry a real id. The After run was captured on a local branch that merges the five sibling entity-link PRs onto db3338b; they touch disjoint files, and this capture only exercisesDeletedKeysTableColumns.tsxBefore (db3338b)
qa-links-userin User ID, Created By and Deleted By, all plain textAfter (3ef7022)
default_user_idas plain text, visible in the same screenshotType
🆕 New Feature
Caveats (if any)
Low
Final Attestation
https://claude.ai/code/session_01NfwfQhamRNnSqgXMUjf3h4