feat(ui): link the User ID and Team ID cells on the Memory page - #40752
Merged
ryan-crabbe-berri merged 1 commit intoSep 12, 2026
Merged
Conversation
Both columns rendered as dead pills, so tracing a memory row back to its owner meant copying an id into another page's search box. IdCell grows an href prop that turns the pill into a client-routed link, and the Memory columns pass the shared entityLinks helpers so the proxy admin and dashboard sentinels stay unlinked. Claude-Session: https://claude.ai/code/session_01NfwfQhamRNnSqgXMUjf3h4
Contributor
Greptile SummaryThis PR makes Memory page user and team identifiers navigable through the existing entity-detail URL conventions.
Confidence Score: 5/5The PR appears safe to merge, with entity URLs encoded correctly and both destination pages honoring the generated query parameters. No actionable failure remains: the shared link handler preserves native new-tab interactions, entity helpers prevent unsafe schemes and sentinel links, and focused tests cover the newly exposed behavior.
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/src/components/shared/table_cells/id_cell.tsx | Adds optional semantic-link rendering while retaining existing plain, clickable, copyable, and disabled cell behavior. |
| ui/litellm-dashboard/src/app/(dashboard)/memory/_components/MemoryTableColumns.tsx | Generates encoded user and team detail links through existing helpers, which suppress known sentinel identifiers. |
| ui/litellm-dashboard/src/components/shared/table_cells/id_cell.test.tsx | Verifies anchor output, client-side routing, and fallback to plain text without an href. |
| ui/litellm-dashboard/src/app/(dashboard)/memory/_components/MemoryTable.test.tsx | Verifies Memory table detail links and confirms built-in user and team sentinels remain unlinked. |
Reviews (1): Last reviewed commit: "feat(ui): link the User ID and Team ID c..." | Re-trigger Greptile
ryan-crabbe-berri
enabled auto-merge (squash)
September 12, 2026 00:46
yuneng-berri
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
How it solves it:
IdCellgrows anhrefprop that turns the pill into a client routed linkuserDetailHrefandteamDetailHref, so sentinels stay unlinkedUser Flow
Before: an admin reviewing stored memories cannot get from a row to the user or team it belongs to
After: the same admin clicks either pill and lands on it
default_user_idas a plain pill, because there is no user page for itRelevant issues
Linear ticket
Pre-Submission checklist
uv run pytest tests/test_litellm/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
Setup: proxy on :4021 and the dashboard dev server on :3021, both against the shared dev database. Seeded memories
zzqa:timezoneandzzqa:prefers-conciseforqa-links-useron teamzzqa-links-team, alongside two older rows owned by the built in admin. The After run was captured on a local branch that merges the five sibling entity-link PRs onto db3338b; they touch disjoint files, and this capture only exercisesid_cell.tsxandMemoryTableColumns.tsxBefore (db3338b)
zzqa:timezonerow shows no links:After (32a6494)
Type
🆕 New Feature
Caveats (if any)
Low
IdCellgains anhrefprop that every other caller leaves unset, so nothing else changeshrefandonClickare passed,hrefwins; no current caller passes bothFinal Attestation
https://claude.ai/code/session_01NfwfQhamRNnSqgXMUjf3h4