Fix setcchar() for an empty wide string - #389
Merged
Merged
Conversation
The combining-character loop read past the terminating zero into the uninitialised rest of the array. Fixes Bill-Gray#388.
Owner
|
Looks good to me as well. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_wchar_to_int32_array()stores only the terminating zero for an empty string, and the combining-character loop insetcchar()then read the uninitialised rest of the array. Bound the loop by the number of characters actually stored.With the
vtport under valgrind,setcchar(&cell, L"", A_NORMAL, 0, NULL)reported "Conditional jump or move depends on uninitialised value(s)" and produced0x110001; it now produces0and valgrind is clean. A combining sequence such asL"é"still round-trips throughgetcchar().Fixes #388.