fix(whisper): ignore empty non-speech token encodings - #934
Open
saichowdary007 wants to merge 2 commits into
Open
fix(whisper): ignore empty non-speech token encodings#934saichowdary007 wants to merge 2 commits into
saichowdary007 wants to merge 2 commits into
Conversation
Fixes Blaizzy#917 Signed-off-by: sai <saikumar@sais-MacBook-Pro.local>
|
Please sign every commit, then update the PR. You can review the commits on the commits tab and follow GitHub's commit-signing guide if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #917.
HFTokenizerWrapper.non_speech_tokensindexed the result of several tokenizerencodes without checking whether the tokenizer returned any tokens. English
only Whisper tokenizers can return an empty list for the seed strings, which
made every transcription fail with
IndexError. Empty encodings are nowignored for both the seed tokens and miscellaneous symbols; existing tokens
and suppression behavior are unchanged.
Testing
.venv/bin/python -m pytest tests/test_whisper_decode_options.py -q(8 passed).venv/bin/pre-commit run --files mlx_audio/stt/models/whisper/whisper.py tests/test_whisper_decode_options.pyThe regression tests cover empty seed encodings and empty miscellaneous-symbol
encodings with lightweight fake tokenizers.
Implementation and test preparation used AI assistance; the submitting
contributor reviewed the changed lines and owns the behavior validation.