feat(models): add the four live catalog models missing from top-models.json - #290
Conversation
…s.json gemini-3.6-flash, gemini-3.5-flash-lite, tencent/hy3 and xiaomi/mimo-v2.5-pro have entries in src/models.ts and are visible in the live BlockRun catalog (/api/v1/models), but never made it into the curated picker allowlist. Surfaced by ClawRouter-Hermes #32, which had to park all four in a POST_TOP_MODELS_ADDITIONS exemption set to get its mirror guard green — that repo curates against this file, so anything missing here is invisible in the Hermes /model picker too. Placement follows the existing grouping: the two Gemini flash tiers beside their siblings, mimo-v2.5-pro after mimo-v2.5, hy3 after the Qwen pair. The list is now identical, entry for entry and in order, to Hermes' CHAT_MODELS (55 each). 798 tests pass, typecheck clean.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe model catalog adds four model identifiers: two Google Gemini models, one Xiaomi model, and one Tencent model. ChangesModel catalog
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The change adds four existing model identifiers to the curated catalog without altering existing entries or runtime dependencies. No actionable merge-blocking risk remains beyond normal checks. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…picker gemini-3.6-flash, gemini-3.5-flash-lite, tencent/hy3 and mimo-v2.5-pro have had entries in src/models.ts and have been visible in the live BlockRun catalog, but none was ever added to src/top-models.json. Everything curating against that file — the picker and every downstream TOP_MODELS consumer — has been blind to all four. Landed in #290; this cuts the release that ships it. dist/ is rebuilt, which is what actually carries top-models.json to consumers: tsup inlines the JSON, so the committed bundle was still serving the old 51-entry list. 798 tests pass, typecheck clean, dist smoke check passes.
Resolves the dist/ conflicts against main (v0.12.262, BlockRunAI#290's four catalog models). The bundles were regenerated from the merged source with `npm run build` rather than accepting git's auto-merge — a textually merged bundle is not a valid build. Postbuild smoke check passes and the full suite is green (831 passed, 1 skipped). No source files conflicted; this touches dist/ only.
1 participant
Summary
google/gemini-3.6-flash,google/gemini-3.5-flash-lite,tencent/hy3andxiaomi/mimo-v2.5-proall have entries insrc/models.tsand are visible in the live BlockRun catalog (https://blockrun.ai/api/v1/models), but were never added tosrc/top-models.json— so they are absent from the curated picker everywhere it is consumed.Surfaced by ClawRouter-Hermes #32: that repo curates against this file, and had to park all four in a
POST_TOP_MODELS_ADDITIONSexemption set to get its mirror guard green. Anything missing here is missing from the Hermes/modelpicker too.Placement
Follows the existing grouping, no reordering of current entries:
google/gemini-3.6-flashgoogle/gemini-3.1-progoogle/gemini-3.5-flash-litegoogle/gemini-3.5-flashxiaomi/mimo-v2.5-proxiaomi/mimo-v2.5tencent/hy3qwen/qwen3.8-flash51 → 55 entries. The list is now identical, entry for entry and in order, to Hermes'
CHAT_MODELS.Tests
npx vitest run: 798 passed (70 files)npm run typecheck: cleanFollow-up
Once this lands, ClawRouter-Hermes can empty its
POST_TOP_MODELS_ADDITIONSset — it exists only to exempt these four.Summary by CodeRabbit