fix: email flag fix to send emails on run complete - #528
Merged
Merged
Conversation
The email flag was silently failing for a few reasons. Inocrrect paths to assets, not passing the header, and not giving feedback on sendmail result. The plaintext email also failed because of not sending the header properly. Now it tries sendmail for the html email, if that fails, it uses the plaintext email as a backup and lets you know this in the console output and in log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The email flag was silently failing for a few reasons. Inocrrect paths to assets, not passing the header, and not giving feedback on sendmail result. The plaintext email also failed because of not sending the header properly. Now it tries sendmail for the html email, if that fails, it uses the plaintext email as a backup and lets you know this in the console output and in log.