Skip to content

TypeScript Improvements and Refactoring on CSVReader | style object type refactoring #149

Description

@berkinanik

I want to mention two issues I faced while using react-papaparse:

  • Poor TypeScript type inference on children render function arguments and prop types for CSVReader component.
  • Too many any type definition, unnecessary CSSProperties type castings and style?: any usages.

I have a fix proposal which includes updating useCSVReader by rewriting many props and type definitions and refactoring all the use cases regarding those updates. Also, updating examples on styling the CSVReader and removing style type castings.

With this properly typed CSVReader component and useCSVReader hook, the component itself and its render children function have proper type inference. Many unnecessary explicit type definitions can be removed. This way typescript support is meaningful since there are no more any type usage in returned component from the useCSVReader hook.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions