test: add unit tests for main and db and improve coverage by Laertes87 · Pull Request #596 · C4illin/ConvertX

Laertes87 · 2026-08-02T12:44:33Z

Summary by cubic

Added comprehensive unit tests for converter discovery/chunking, DB init/migration, file-type normalization/output mapping, and version logging to improve coverage and ensure stable behavior. Tests run against an isolated temp SQLite DB via DB_PATH and avoid flakes by importing after env setup and waiting for async callbacks.

Refactors
- Exported chunks/mainConverter from src/converters/main.ts and filters/getFilters from src/converters/libreoffice.ts as @internal for tests.
- Introduced initializeDatabase; DB setup now respects DB_PATH, creates the parent directory, enables WAL, and performs an idempotent v0→v1 migration (case-insensitive check for missing status column; only updates user_version when needed).
- Hardened version parsing/output in src/helpers/printVersions.ts; tests verify production vs. non-production output and error paths for missing tools.
- Added bunfig.toml to enable coverage and exclude tests/converters/helpers/commonTests.ts; tests ensure default db export works and clean up connections plus WAL/SHM files.

^{Written for commit ee8137b. Summary will update on new commits.}

cubic-dev-ai

All reported issues were addressed across 7 files

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 4 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 1 file (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 2 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 2 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 14 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 2 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

Laertes87 · 2026-08-04T08:10:51Z

@C4illin I think this PR is done for now. Every converter and every helper is covered by unit tests now. The only files not covered in those subdirectories now are types, the env.ts and the tailwind.ts. Those don't contain relevant program logic that would need testing, though.

I guess the next step woould be tests for the frontend components and pages. But that's a task for a different PR. The backend should be covered for now.

C4illin · 2026-08-04T19:50:49Z

+  delete process.env.MOCK_EXEC_ERROR;
+});
+
+test("druckt nur die Version und beendet sich sofort, wenn NODE_ENV nicht production ist", async () => {


english would be nice :)

Awww man, I should not write code when I'm already half asleep. I was on a voice call with an American friend once and I wasn't really awake anymore at 4 am. I just defaulted to German at one point. 😆

C4illin · 2026-08-04T19:50:58Z

+  expect(readFile).not.toHaveBeenCalled();
+});
+
+test("druckt System-Infos und Tool-Versionen im Production-Modus", async () => {


C4illin · 2026-08-04T19:51:04Z

+  expect(exec).toHaveBeenCalledTimes(17); // Entspricht exakt der Anzahl der exec-Aufrufe im Quellcode
+});
+
+test("loggt Fehlerpfade wenn Tools fehlen", async () => {


C4illin · 2026-08-04T19:51:10Z

+  expect(consoleErrorSpy).toHaveBeenCalledWith("Bun is not installed. wait what");
+});
+
+test("verarbeitet Ausgabe-Parsing korrekt und loggt keine Fehler im Erfolgsfall", async () => {


C4illin · 2026-08-04T19:59:59Z

-const dbVersion = (db.query("PRAGMA user_version").get() as { user_version?: number }).user_version;
-if (dbVersion === 0) {
-  db.exec("ALTER TABLE file_names ADD COLUMN status TEXT DEFAULT 'not started';");
  db.exec("PRAGMA user_version = 1;");


Wont this reset user version to 1 every time?

You are right, that statement needs to be in the else if branch as well.

cubic-dev-ai

All reported issues were addressed across 4 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

Laertes87 · 2026-08-04T23:16:29Z

@C4illin I addressed your comments. I hope that is fine now. The db initialization and update should also be a bit more robust now.

github-actions Bot added Test and removed Test labels Aug 2, 2026

cubic-dev-ai Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread tests/db/db.test.ts Outdated

Comment thread tests/db/db.test.ts

Comment thread tests/db/db.test.ts

Comment thread tests/converters/main.test.ts

Comment thread tests/converters/libreoffice.test.ts

github-actions Bot added Test and removed Test labels Aug 2, 2026

cubic-dev-ai Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread src/db/db.ts

Comment thread tests/converters/main.test.ts Outdated

github-actions Bot added Test and removed Test labels Aug 2, 2026

cubic-dev-ai Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread tests/converters/main.test.ts Outdated

github-actions Bot added Test and removed Test labels Aug 2, 2026

cubic-dev-ai Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread src/db/db.ts Outdated

github-actions Bot added Test and removed Test labels Aug 2, 2026

cubic-dev-ai Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread tests/converters/main.test.ts Outdated

github-actions Bot added Test and removed Test labels Aug 2, 2026

cubic-dev-ai Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread tests/converters/xelatex.test.ts Outdated

Comment thread tests/converters/potrace.test.ts Outdated

github-actions Bot removed the Test label Aug 2, 2026

Laertes87 added 7 commits August 4, 2026 00:54

test: ensure that migrateDb database always gets cleaned up

823c83e

test: do not silently swallow every unexpected error

81334c7

test: fix test name and comment

6fac7cb

test: test the actual default export

152be90

test: test that handleConvert does not throw

ecfa591

test: remove dead mock code line

2fa4dcf

test: consolidate db test

310a065

github-actions Bot added Test and removed Test labels Aug 4, 2026

cubic-dev-ai Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread tests/converters/main.test.ts

Comment thread tests/converters/main.test.ts Outdated

Laertes87 added 2 commits August 4, 2026 09:32

test: ensure that module is loaded after environment variable is set

46705b6

test: wait for resolves to finish before assertion

86cf842

github-actions Bot added Test and removed Test labels Aug 4, 2026

C4illin reviewed Aug 4, 2026

View reviewed changes

Laertes87 added 3 commits August 4, 2026 23:35

test: fix test name and comment language

bbe5748

test: make sure to only update database version if needed

0e91478

test: improve readability of sql in db test

ce540ca

github-actions Bot added Test and removed Test labels Aug 4, 2026

cubic-dev-ai Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread src/db/db.ts Outdated

test: make check for status column case-insensitive

ee8137b

github-actions Bot added Test and removed Test labels Aug 4, 2026

Uh oh!

Conversation

Laertes87 commented Aug 2, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Laertes87 commented Aug 4, 2026

Uh oh!

C4illin Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

Laertes87 Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

C4illin Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

C4illin Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

C4illin Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

C4illin Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

Laertes87 Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Laertes87 commented Aug 4, 2026

Uh oh!

Reviewers

Laertes87 commented Aug 2, 2026 •

edited by cubic-dev-ai Bot

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

Laertes87 Aug 4, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading