370 twistlock scan - #128
Open
tracy18 wants to merge 13 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Twistlock container scanning after image builds and updates key GitHub Actions dependencies.
Changes:
- Adds per-image Twistlock scans and aggregated vulnerability reporting.
- Integrates scan results into workflow gating and Slack notification dependencies.
- Upgrades checkout and AWS credential actions.
Suppressed comments (1)
.github/workflows/build-all.yml:324
- Certificate validation is also disabled on this authenticated request, exposing the Twistlock credentials to interception. Use the trusted system CA or an explicitly configured internal CA rather than
--insecure.
--insecure \
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| TWISTLOCK_PATH="${RUNNER_TEMP}/twistcli" | ||
|
|
||
| curl --fail --silent --show-error --location --insecure -u "${{ secrets.TWISTLOCK_USERNAME }}:${{ secrets.TWISTLOCK_PASSWORD }}" --output "${TWISTLOCK_PATH}" "${TWISTLOCK_URL}/api/v1/util/twistcli" |
| gh_out.write("critical_count=0\n") | ||
| gh_out.write("high_count=0\n") | ||
| gh_out.write("has_critical_or_high=false\n") | ||
| sys.exit(0) |
Comment on lines
+544
to
+546
| - name: Fail if any image has critical/high vulnerabilities | ||
| #if: env.ANY_CRITICAL_OR_HIGH == 'true' | ||
| if: needs.twistlock_scan.result == 'failure' |
| name: Slack Notification | ||
| runs-on: ubuntu-latest | ||
| needs: [build] | ||
| needs: [build, twistlock_scan, twistlock_summary] |
Comment on lines
+242
to
+243
| outputs: | ||
| backend_scan_result: ${{ steps.set_scan_output.outputs.scan_result }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
N/A
Change Details (Specifics)
N/A
Related Ticket(s)
N/A