Skip to content

Revert "Set node version to 23.1 (#8280)" #8301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emyl3 merged 1 commit into from
Nov 25, 2024
Merged

Revert "Set node version to 23.1 (#8280)" #8301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/checkGraphql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
- main

env:
NODE_VERSION: 23.1
NODE_VERSION: 23

defaults:
run:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/chromatic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
- "frontend/**"

env:
NODE_VERSION: 23.1
NODE_VERSION: 23

jobs:
chromatic-deployment:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/coverity.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ on:
env:
JAVA_VERSION: 17
JAVA_DISTRIBUTION: 'zulu'
NODE_VERSION: 23.1
NODE_VERSION: 23

defaults:
run:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deployDemo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

env:
DEPLOY_ENV: demo
NODE_VERSION: 23.1
NODE_VERSION: 23

concurrency:
group: demo-deploy
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deployDev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ on:
- pentest

env:
NODE_VERSION: 23.1
NODE_VERSION: 23

concurrency:
group: ${{ github.event.inputs.deploy_env }}-deploy
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deployProd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

env:
DEPLOY_ENV: prod
NODE_VERSION: 23.1
NODE_VERSION: 23

concurrency:
group: prod-deploy
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deployStg.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

env:
DEPLOY_ENV: stg
NODE_VERSION: 23.1
NODE_VERSION: 23

concurrency:
group: stg-deploy
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deployTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

env:
DEPLOY_ENV: test
NODE_VERSION: 23.1
NODE_VERSION: 23

concurrency:
group: test-deploy
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deployTraining.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

env:
DEPLOY_ENV: training
NODE_VERSION: 23.1
NODE_VERSION: 23

concurrency:
group: training-deploy
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/maintenance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ on:
default: "prod"

env:
NODE_VERSION: 23.1
NODE_VERSION: 23

jobs:
pushMaintenanceBlob:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ concurrency:
cancel-in-progress: true

env:
NODE_VERSION: 23.1
NODE_VERSION: 23
JAVA_VERSION: 17
JAVA_DISTRIBUTION: 'zulu'
PROJECT_ROOT: /home/runner/work/prime-simplereport/prime-simplereport # Hardcoding this here because env.WORKSPACE_ROOT gets overridden by one of the steps downstream. We only need this for Sonar.
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
23.1.*
23.*
2 changes: 1 addition & 1 deletion frontend/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
23.1.*
23.*
4 changes: 2 additions & 2 deletions frontend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:23.1-alpine as build
FROM node:23-alpine as build
LABEL org.opencontainers.image.source https://github.com/CDCgov/prime-simplereport

# Add bash and git
Expand Down Expand Up @@ -49,7 +49,7 @@ RUN echo "REACT_APP_CONTENT_SECURITY_POLICY_SCRIPT_SRC=''" >> .env.production.lo
RUN yarn run build

# production environment
FROM node:23.1-alpine
FROM node:23-alpine
RUN npm install -g serve
WORKDIR /app/frontend
COPY --from=build /app/frontend/build /app/frontend/build
Expand Down
2 changes: 1 addition & 1 deletion frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.1.0",
"private": true,
"engines": {
"node": "~23.1"
"node": "23"
},
"dependencies": {
"@apollo/client": "^3.8.3",
Expand Down