Skip to content

rstr - add blocked rstr build/reuse util - #2061

Merged
jeremylt merged 2 commits into
mainfrom
jeremy/get-blocked
Sep 30, 2026
Merged

jeremylt merged 2 commits into
mainfrom
jeremy/get-blocked

Conversation

@jeremylt

Copy link
Copy Markdown
Member

Purpose:

Should clean up duplicate allocations

Closes: #N/A

LLM/GenAI Disclosure:

None

@jeremylt

Copy link
Copy Markdown
Member Author

@hughcars not sure why GitHub won't let me request a review from you, but I think this does what you want in your first commit, but in a way that I can fix the problem in a couple of places.

@jeremylt
jeremylt force-pushed the jeremy/get-blocked branch 2 times, most recently from caa7e38 to f767946 Compare September 30, 2026 06:51
@jeremylt

Copy link
Copy Markdown
Member Author

Not sure why only the PETSc examples are showing some sort of double free

@jeremylt

Copy link
Copy Markdown
Member Author

Ok, all sorted

@zatkins-dev

Copy link
Copy Markdown
Collaborator

there's a few legitimately uncovered code paths in code cov, up to you if we want to make sure we hit them or not.

@zatkins-dev

Copy link
Copy Markdown
Collaborator

@hughcars not sure why GitHub won't let me request a review from you, but I think this does what you want in your first commit, but in a way that I can fix the problem in a couple of places.

It's because they're not a collaborator on the repo

@jeremylt

Copy link
Copy Markdown
Member Author

Yeah, I'm not worried since this is a reshuffling of existing code instead of new functionality.

@hughcars

Copy link
Copy Markdown
Contributor

Thanks, this covers what my first commit on #2060 was after, and fixes it in the other backends too. I'll drop that commit and rebase once this is in.

@jeremylt
jeremylt merged commit 4958ae1 into main Sep 30, 2026
44 of 45 checks passed
@jeremylt
jeremylt deleted the jeremy/get-blocked branch September 30, 2026 16:56
@hughcars

hughcars commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

On Graviton5 (64 ranks, GCC 13), BP1-6 at p = 1-8 against main 6dc68d4, 3 paired rounds: xsmm/blocked +1.9%, sve/blocked +1.9%, opt/blocked +1.2%. Most of it is at p = 1 (+4.0 to +4.7%) and in BP5 (+3.6 to +4.1%). The only significant losses are small, on opt/blocked BP4 (up to 0.5%).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants