Little fixes to facilitate the sharr evaluation - #405
Merged
Conversation
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| black | 30 | 1 | 1.05s | ||
| ✅ PYTHON | pylint | 30 | 0 | 5.7s |
See detailed report in MegaLinter reports
jmafoster1
force-pushed
the
jmafoster1/sharr-fixes
branch
from
August 3, 2026 12:55
70ae3d8 to
d69008a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
- Coverage 98.54% 98.48% -0.07%
==========================================
Files 25 25
Lines 1514 1517 +3
==========================================
+ Hits 1492 1494 +2
- Misses 22 23 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Collaborator
Author
|
Looking at the codecov report, there's not actually anything missing, it's just that the codebase has got slightly smaller. |
jmafoster1
marked this pull request as ready for review
August 17, 2026 12:21
jmafoster1
force-pushed
the
jmafoster1/sharr-fixes
branch
from
August 17, 2026 12:29
1061367 to
63084f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes
hill_climber_discovery.pyforloop for generational process instead of awhile'causal_dag.py`
add_edges_fromto include a check for cycles__main__.pyOutputting raw discovered DAG rather than a pretty rendering of passing/failing test results.
Tests for the above.