Skip to content

Little fixes to facilitate the sharr evaluation - #405

Merged
jmafoster1 merged 7 commits into
mainfrom
jmafoster1/sharr-fixes
Aug 19, 2026
Merged

Little fixes to facilitate the sharr evaluation#405
jmafoster1 merged 7 commits into
mainfrom
jmafoster1/sharr-fixes

Conversation

@jmafoster1

@jmafoster1 jmafoster1 commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Main changes

hill_climber_discovery.py

  • Normalising fitness by number of generated tests
  • Using a for loop for generational process instead of a while

'causal_dag.py`

  • Override add_edges_from to include a check for cycles
  • Removed resulting dead code cycle check from constructor

__main__.py
Outputting raw discovered DAG rather than a pretty rendering of passing/failing test results.

Tests for the above.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ PYTHON black 30 1 1.05s
✅ PYTHON pylint 30 0 5.7s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@jmafoster1
jmafoster1 force-pushed the jmafoster1/sharr-fixes branch from 70ae3d8 to d69008a Compare August 3, 2026 12:55
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.48%. Comparing base (e753b1e) to head (63084f6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   98.54%   98.48%   -0.07%     
==========================================
  Files          25       25              
  Lines        1514     1517       +3     
==========================================
+ Hits         1492     1494       +2     
- Misses         22       23       +1     
Files with missing lines Coverage Δ
causal_testing/__main__.py 99.16% <100.00%> (+<0.01%) ⬆️
causal_testing/causal_testing_framework.py 100.00% <100.00%> (ø)
causal_testing/discovery/hill_climber_discovery.py 100.00% <100.00%> (ø)
causal_testing/discovery/nsga_discovery.py 100.00% <100.00%> (ø)
causal_testing/specification/causal_dag.py 99.56% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e0d3cc...63084f6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmafoster1

Copy link
Copy Markdown
Collaborator Author

Looking at the codecov report, there's not actually anything missing, it's just that the codebase has got slightly smaller.

@jmafoster1
jmafoster1 requested a review from jwhogg August 17, 2026 12:14
@jmafoster1
jmafoster1 marked this pull request as ready for review August 17, 2026 12:21
@jmafoster1
jmafoster1 force-pushed the jmafoster1/sharr-fixes branch from 1061367 to 63084f6 Compare August 17, 2026 12:29

@jwhogg jwhogg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmafoster1
jmafoster1 merged commit 5cda421 into main Aug 19, 2026
15 of 16 checks passed
@jmafoster1
jmafoster1 deleted the jmafoster1/sharr-fixes branch August 19, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants