Wip/rboachie/ie 962 persistence layer replacement - #11
Open
RbkGh wants to merge 12 commits into
Open
Conversation
…endency removed in database.js
…endency removed in database.js, docker-compose updates & others
…ern of res to affect application wide calls
jlee-cl
suggested changes
Dec 20, 2022
| queryValues: [type], | ||
| additionalWhereStmts: type ? 'type = ?' : '' | ||
| }).then((data) => { | ||
| }, next).then((data) => { |
There was a problem hiding this comment.
db.getData doesn't take a next argument.
uniroster-server/utils/database.js
Line 36 in d6b83e3
Author
There was a problem hiding this comment.
Yeah, I don't know how I forgot that because I removed it, anyway, thanks. I've pushed the change.
| }; | ||
|
|
||
| const buildSelectStmt = function(req, res, tableFields, sqlParams) { | ||
| const buildSelectStmt = function(req, res, tableFields, sqlParams,next) { |
There was a problem hiding this comment.
The next argument isn't used in the function.
| }; | ||
|
|
||
| var buildWhereStmt = function(req, res, tableFields, sqlParams) { | ||
| var buildWhereStmt = function(req, res, tableFields, sqlParams,next) { |
There was a problem hiding this comment.
The next argument isn't used in the function.
…ademicsessions.js
jlee-cl
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.