fix: use $eq for history.prime query in getAllVersions - #316
Merged
Merged
Conversation
Wrap the user-derived @id in a MongoDB $eq operator so it is treated as a literal value rather than a query object, closing the NoSQL injection code-scanning alert (js/sql-injection) in getAllVersions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the one still-relevant change from #211 (which is being closed as superseded): the NoSQL injection fix in
getAllVersions.controllers/utils.jsbuilds a MongoDB query from a user-derived@id:If
@idis a query object (e.g.{$ne: null}), MongoDB interprets it as an operator, allowing query injection. Wrapping the value in$eqforces it to be treated as a literal:This is the same fix that closed code-scanning alert #69 on the #211 branch; the equivalent alert remains open on
main(js/sql-injection,controllers/utils.js).Validation
__tests__/utils.test.js+__tests__/routes_mounted.test.js: 70/70 passroutes/__tests__/release.test.js: 3/3 pass (release logic usesgetAllVersions)Related
getAllVersionsquery