feat: split token-quote availability from route coverage - #1787
Merged
Conversation
Add token_quote_api_ok_total counter (HTTP 200 regardless of outAmount) and RecordProbeDetailed(apiOk, routeFound) in all 6 provider adapters. YAML gets availability and coverage_given_available query slots per provider.
- publishedAt 2026-08-04 -> 2026-08-05 - Mobula aggregate 677 -> 678 ms (2 occurrences: table + scorecard) - GeckoTerminal aggregate 12,340 -> 12,319 ms (3 occurrences) - StatTable caption: p50 -> mean of per-chain p50s - Removed speculative Mobula Solana mechanism sentence; replaced with caveated explanation noting reorg exposure - 8.2x Mobula-Base gap -> 7.9x (773/98) - RH Chain 4x faster blocks -> 2x faster block cadence (Base 200ms/RH 100ms) - 28 pp wallet-labels gap -> 24 pp (79.9 - 55.6 = 24.3) - Quote section: removed 'entire cohort' claim; fixed Mobula framing to reference availability confound instead of 29% miss rate - Methodology: removed dangling Singapore regional-table reference - coverage_given_success -> coverage_given_available (correct metric name) - Removed auto-rendered duplicate citation block from page.tsx layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
token_quote_api_ok_totalPrometheus counter (incremented on HTTP 200, regardless of outAmount) alongside the existingsuccessandattemptscountersRecordProbe(ok bool)withRecordProbeDetailed(apiOk, routeFound bool)in all 6 provider adapters (jupiter, kyberswap, mobula, odos, paraswap, relay)availabilityandcoverage_given_availablequery slots to each provider inbenchmarks/token-quote-coverage.ymlWhy: Previously
p50 == p99 == mean == successbecause all four slots computed the samesuccess/attemptsratio. Network errors and API 4xx were conflated with "no route found" making it impossible to tell if a low score meant the API was down or the routing engine had gaps.After this change:
availability= api_ok / attempts (is the API up and returning 200?)coverage_given_available= success / api_ok (given the API responded, did it find a route?)p50stays as success / attempts to preserve historical continuityDeploy
Harness needs rebuild on VPS after merge:
docker build --no-cacheonocb-par-mainfor thetoken-quote-coverageservice. New counter starts accumulating from restart; old data is unaffected.