Skip to content

tests/consumer/functional/ is in no CI job path, so the registration tests never run #23

Description

@saqibmanan

tests/consumer/functional/ is in no CI job's path. The jobs run:

  • consumer-smoke → tests/consumer/smoke
  • api-smoke → tests/api/smoke
  • provider-smoke → tests/provider/smoke

So the three registration tests added in #21 — including the privacy-consent enforcement check — never execute in CI. They pass locally against dev.

Worth a deliberate decision

There is a real argument for leaving it: those tests create real user accounts in the Keycloak realm. They clean up in fixture teardown and skip entirely when no admin token is available, so they are safe, but not running them on every push is a defensible default rather than an oversight.

The problem is that it currently is an oversight — the path simply was never added, and nothing records the choice.

Options:

  1. Leave as-is and document that tests/consumer/functional/ is local/manual only.
  2. Add the path to consumer-smoke, which already selects smoke or functional on workflow_call and workflow_dispatch, so the registration tests would run on deploys but not on every push.
  3. Run them on a schedule rather than per-merge.

Option 2 matches the existing marker logic most closely.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions