fix(provider): read sectors from the backend; clearer combobox and rate-limit failures - #128
Merged
Merged
Conversation
…aborativeTestData.SECTORS
…viving the post-create re-render
…ting stops looking like flakiness
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the provider-smoke failures that have been red on every recent
CIpush and PR (for example #122 and #124: prv_006, 006b, 007, 011 and 012).Root cause: stale test data, not load
The 2026-09-24 dev refresh from prod replaced the sector list. "Budgets" no longer exists on dev, whose 8 sectors are now Child Rights, Public Finance, Law And Justice, and so on. Eleven provider tests hardcoded it. The combobox never offered the option, so each test died with a blank
TimeoutExceptionon every rerun, which looked exactly like the old contention failures.I checked the other hardcoded taxonomy values against dev (India/Assam, SDG 13, the Budget/Finance tags). All of them still exist.
Changes
sector_namefixture (session scope): reads{ sectors { name } }live fromAPI_BASE_URL, the same pattern asbackend_enum_labels. All 11 tests use it, and the staleSECTORSconstants and aliases are removed fromtests/data.BasePage.wait_for_option()is used byselect_combobox_optionand the AI model picker. On timeout it raisesNo option 'X' after Ns. Options listed: [...], scoped to that input's own listbox so the Bhashini language options don't show up.go_to_metadata_tabusesclick_until. After "Dataset created successfully" the form can re-render into "Loading" once more.test_prv_002hitElementClickInterceptedon the tab because of this.Evidence (headless,
-n 3, against dev)CIbefore the fix,-m smoke-m smoke-m "smoke or functional"The new timeout message was checked by forcing the fixture to "Budgets":
No option 'Budgets' after 30s. Options listed (filtered by the typed text): [...], on both the BasePage and AI model paths. The 429 section was checked while the backend was actually throttled.Not changed, worth a look
test_prv_008_org_add_chartsXPASSes andtest_prv_004_ind_add_chartsstill XFAILs. Both carryxfail("Charts feature isn't fully built yet"). Either charts now work for orgs and 004 has a real test bug, or 008 passes by accident. One XPASS isn't enough to drop the marker, andstrict=Falsekeeps it harmless.