test: /publishers JSON-LD has a name and description (DataSpaceFrontend #443) - #140
Merged
Merged
Conversation
saqibmanan
marked this pull request as ready for review
September 25, 2026 19:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: CivicDataLab/DataSpaceFrontend#443 (merge
f7141e84, merged todev2026-09-08). Base:CI. This covers only the/publishersJSON-LD part of that PR, which was otherwise an ESLint/type-safety refactor.#443 is on
main, and both dev and prod serve the fixed block today, so this test isreadonlyand safe for the prod deploy gate.What changed (from the diff)
PublishersListingClient.tsxbuilds a schema.org JSON-LD block for the/publisherspage.nameanddescriptionwere read fromDetails?.data?.getPublishers?.title/.description, butgetPublishersreturns a list, so both wereundefinedandJSON.stringifydropped them. The block never had a name or description. #443 sets both explicitly ("Our Publishers" plus a description).What this adds
tests/api/smoke/test_api_012_publishers_jsonld.py(api+seo+smoke, module-levelreadonly): GET/publishers, parse theapplication/ld+jsonblocks, find the single one whoseurlends in/publishers, and require non-empty stringnameanddescription. The block is server-rendered, so a plain GET is enough and no browser is needed.It's marked
smokeso it runs on PRs (api-smokeselects-m "smoke"). The existingseositemap tests (test_api_006) have nosmokemarker, so they only run under the readonly prod gate. It asserts only that the fields are present and non-empty, not the exact copy, so wording changes don't break it.Proof (local)
Collected under both CI filters:
Green, dev and prod:
Red, pre-#443 code: the old expression evaluated in Node against a list-shaped
getPublishersproduced{"@context":"https://schema.org","@type":"Dataset","url":".../publishers","publisher":{...}}(noname, nodescription). Served locally and tested:Gaps
/publishers/<slug>) were only type-annotated in #443, with no behaviour change, so they aren't covered here.