Skip to content

28 Django tests are stale after the chart and metadata refactors #189

Description

@saqibmanan

What: 28 Django tests fail on dev — tests/object_types/charts/* (23) and tests/schema/test_dataset_schema.py::TestAddUpdateDatasetMetadata (5). They were left behind by the chart consolidation and the metadata refactor.

Why it matters: they are excluded from the new Django Tests CI job, so that code has no coverage.

Evidence: BaseChart.__init__() takes 2 positional arguments but 4 were given; AttributeError: Mock object has no attribute '_state'.

Fix: not fixed — update the tests to the current signatures, then drop the --ignore/--deselect from .github/workflows/django-tests.yml. Note test_grouped_bar_chart.py also had a syntax error (duplicate options kwarg, JS true) repaired in #188; before that the whole suite failed to collect.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't working

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions