Add a Storage options tab and client log rotation - #1073
Conversation
|
Nightly build for this pull request:
|
|
Log and replays ok. Would you kindly add this feature and for game saves too? |
I've added that. With 0/unlimited so no saved games get deleted unless the user changes the setting. Also updated the docs as I missed a bit when changing to 20 instead of 5 files. |
Fix a comment
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Continue with pruning on failure
6cde825 to
0d7e981
Compare
Do we really need to explain that much to players? I prefer just saying nothing
|
Better to keep the description |
|
How about change to |
Sounds good. The original text seems hard to understand (I simulated regular players with a tired mind and found I can't read that sentence) |
Co-Authored-By: 11EJDE11 <194312388+11EJDE11@users.noreply.github.com>
| var lblGameLogRetentionHint = new XNALabel(WindowManager); | ||
| lblGameLogRetentionHint.Name = nameof(lblGameLogRetentionHint); | ||
| lblGameLogRetentionHint.ClientRectangle = new Rectangle(12, lblGameLogFolderSize.Y + ROW_SPACING, 0, 0); | ||
| lblGameLogRetentionHint.Text = ("The game's debug folder: its logs and the snapshots saved for crashes and desyncs.\n" + |
There was a problem hiding this comment.
@11EJDE11 Can you also shorten this text? This should be my last review comment.
3 participants
Adds a Storage tab to the options window, and replaces the single
client_previous.logbackup with proper log rotation.Today the client keeps one old log:
client.logis copied overclient_previous.logon every start. Logs are now renamed to a timestamped backup and pruned to a configured file count and total folder size(
[ClientLogs]MaxKeptLogFiles,MaxLogFolderSizeMB), which addresses #1021.Retention is read straight from the settings INI rather than through
UserINISettings, because rotation runs before that is initialised.Note: Screenshots show the replay options - these will be added in a later PR and are opt-in. For now, it's just the client logs.