London | 26-ITP-May | Talia Kucuk | Sprint 3| Coursework/sprint 3 implement and rewrite - #1565
Open
TaliaKucuk wants to merge 6 commits into
Open
Conversation
TaliaKucuk
added
the
Needs Review
cjyuan
added
Review in progress
cjyuan
reviewed
Jul 27, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Could you also implement the Jest tests in Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest?
Comment on lines
+17
to
+21
| function getAngleType(angle) | ||
| { | ||
| if (angle > 0 && angle < 90) { | ||
| return "Acute angle"; | ||
| } else if (angle === 90) { |
Contributor
There was a problem hiding this comment.
Indentation is slightly off.
Have you installed the prettier VSCode extension and enabled "Format on save/paste" on VSCode,
as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md
?
Comment on lines
+40
to
+50
| // Numerator > denominator | ||
| assertEquals(isProperFraction(4, 1), false); | ||
|
|
||
| // Numerator === denominator | ||
| assertEquals(isProperFraction(2, 2), false); | ||
|
|
||
| // Numerator is 0 | ||
| assertEquals(isProperFraction(0, 4), false); | ||
|
|
||
| // Denominator is 0 | ||
| assertEquals(isProperFraction(6, 0), false); No newline at end of file |
Contributor
There was a problem hiding this comment.
What authoritative source do you base your definition of a proper fraction on?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Submission for Coursework/sprint 3 implement and rewrite