London | 26-ITP-May | Gideon Defar | Sprint 3 | Project-TV-Show Level-500 - #95
Open
gideondefar wants to merge 19 commits into
Open
London | 26-ITP-May | Gideon Defar | Sprint 3 | Project-TV-Show Level-500#95gideondefar wants to merge 19 commits into
gideondefar wants to merge 19 commits into
Conversation
London | ITP-May-26 | Gideon Defar | Sprint 1 | Project TV Show- feature/level-100
London | 26-ITP-May | Gideon Defar | Sprint 3 | Project-TV-Show Level-300
London | 26-ITP-May | Gideon Defar | Sprint 3 | Project-TV-Show Level-300-API
London | ITP-May-26 | Vito Moratti | Sprint 3 | Project TV Show/level-400
London | 26-ITP-May | Gideon Defar | Sprint 3 | Project-TV-Show Level-500
gideondefar
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Implemented the Level 500 shows listing and accessibility improvements.
Added a shows listing view using a responsive 2-column grid layout.
landmark.Added dual-mode search for shows and episodes.
Added back navigation between the shows listing and episode view.
Implemented in-memory API response caching to avoid unnecessary repeated fetches.
Improved accessibility by adding appropriate ARIA labels and a semantic
Improved colour contrast to address Lighthouse accessibility issues.
Tested the application locally and verified the deployed version.
Link to my live website: https://tv-show-pro.netlify.app/
Link to my partner's live website: https://vmoratti.github.io/Project-TV-Show/