Conversation
|
Thanks for taking over! Please reverence the original PR in the first comment this PR is replacing. |
|
As mentioned in #5366 we need to move forEachCell into PMacc first. One of the reasons is that we have two different licenses, one for PMacc and one for PIConGPU, if the code is going mainline we should have yhe correct license in. |
At least the TBG documentation rst file automatically includes the TBG_macros. Is there a separate rst file, that this should be referenced in?
I can do that. Where in PMacc should it go? Do I need to do something more specific than moving the definition and make sure everything is properly included as neccessary? |
|
@psychocoderHPC @steindev Please have a look, when you are back. After looking in the ci logs, apparently it works on some configurations but fails in others. |
|
Since I don't know a better way to run these tests, I will push a couple of times. Please excuse this. |
c93f9c8 to
d950c95
Compare
|
@chillenzer Please have a look at the pypicongpu and picmi changes. |
psychocoderHPC
left a comment
There was a problem hiding this comment.
we need to wait for @chillenzer green 👍
There was a problem hiding this comment.
Please explain the physical setup of the test as well.
chillenzer
left a comment
There was a problem hiding this comment.
Only reviewed the Python part for now. Looks plausible, some naming suggestions.
f826814 to
8f2a231
Compare
…ged gas densities With this commit PIConGPU provides a poisson solver to generate the electric field during the starting conditions. It can be activated by providing the `--poisson.activate` flag when starting a picongpu simulation. See TBG docu and `picongpu --help` for more options. A test for the Poisson solver is also provided. Co-authored-by: René Widera <r.widera@hzdr.de> Co-authered-by: Luca <pennati@kth.se>
There is now a way to use it in both frameworks. It probably needs some more documentation though.
ff584ae to
c203ce5
Compare
Provide poisson solver
This is a continuation of PR #5366.
The poison solver is only solving the E-Field for the initial gas density not for densities created during the slide!
Use
picongpu --helpto see how to enable the poison solveroutput during execution
Requires PR #5729