Skip to content

fix(opencode): system llvm for cargo-llvm-cov (v3 concurrency) - #1089

Open
seonghobae wants to merge 2 commits into
mainfrom
fix/opencode-coverage-llvm-tools-v3
Open

fix(opencode): system llvm for cargo-llvm-cov (v3 concurrency)#1089
seonghobae wants to merge 2 commits into
mainfrom
fix/opencode-coverage-llvm-tools-v3

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Same llvm bake as #1081 / #1072 so OpenCode Review Dispatch coverage-evidence can run cargo-llvm-cov on Rust repos.

Why v3

Unblocks

  • TEPP#46 commercialization serial (local CI green; blocked only on central OpenCode APPROVE after llvm bake).

Test plan

Summary by CodeRabbit

  • 개선 사항
    • 코드 커버리지 측정 환경에서 LLVM 도구를 안정적으로 사용할 수 있도록 개선했습니다.
    • 시스템에 설치된 LLVM 도구를 자동으로 감지하고 실행 경로를 설정합니다.

@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f0863e37-f54a-4af3-8b82-37d20676bcc7

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 33291f64-fc49-4b06-976a-38de79d5add1

📥 Commits

Reviewing files that changed from the base of the PR and between c47afc2 and 16d2301.

📒 Files selected for processing (1)
  • .github/workflows/opencode-review-dispatch.yml

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Coverage 이미지에 LLVM을 설치하고 llvm-covllvm-profdata를 고정 경로로 연결합니다. Rust toolchain 초기화는 명시적 설정이 없을 때 시스템 LLVM 경로를 사용합니다.

Changes

LLVM coverage toolchain

Layer / File(s) Summary
Coverage 이미지의 LLVM 도구 설치
.github/workflows/opencode-review-dispatch.yml
이미지에 llvm를 설치합니다. llvm-covllvm-profdata를 탐색한 후 /usr/local/bin에 심볼릭 링크를 생성합니다. LLVM_COVLLVM_PROFDATA를 고정 경로로 설정합니다.
Rust toolchain의 LLVM 경로 보완
.github/workflows/opencode-review-dispatch.yml
LLVM_COV 또는 LLVM_PROFDATA가 없으면 시스템에서 검색한 실행 파일 경로를 설정합니다. 기존 환경 변수는 유지합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 16d23

This PR makes a localized workflow change to provide system LLVM tooling for coverage checks. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 system LLVM을 사용해 cargo-llvm-cov를 지원하는 주요 변경 사항을 명확하게 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/opencode-coverage-llvm-tools-v3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Opened as v3 because #1081 concurrency group is held by non-terminating cancelled model-pool job. Priority unblock for ContextualWisdomLab/TEPP#46. Land this; close #1081/#1072 as superseded.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head repair (2026-08-19)\n\nRebased the isolated LLVM coverage-image/toolchain change onto current main and pushed 18af550. The workflow now installs LLVM, resolves versioned llvm-cov/llvm-profdata into fixed paths, and preserves rustup fallback behavior.\n\nEvidence: rebase clean and git diff --check passed. Local actionlint was attempted with a 30-second bound but the large workflow did not complete locally; protected GitHub checks must provide the authoritative workflow validation. No merge claimed.

@seonghobae
seonghobae force-pushed the fix/opencode-coverage-llvm-tools-v3 branch from 884d0ae to 1e6a5e6 Compare August 19, 2026 09:44
@seonghobae

Copy link
Copy Markdown
Contributor Author

Rebased onto current main 9e9f59f3; exact head 1e6a5e67; git diff --check passed. Local actionlint remains unavailable because the workflow lint command hung; no pass is claimed. Project #1 is In Progress.

Copy link
Copy Markdown
Contributor Author

@opencode-agent Review exact current head 1e6a5e67e12ca84c295b931a697b6442926747a5. All repository Actions checks are green. Verify the system LLVM coverage producer is pinned/bounded and fixes Rust cargo-llvm-cov evidence without weakening coverage semantics; submit the formal exact-head verdict.

@opencode-agent
opencode-agent Bot disabled auto-merge August 19, 2026 13:31
@seonghobae
seonghobae force-pushed the fix/opencode-coverage-llvm-tools-v3 branch from 1e6a5e6 to 52faa66 Compare August 19, 2026 15:26
@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head evidence: rebased the system-LLVM/cargo-llvm-cov repair onto main bbedc1a. Exact head 52faa66. Focused Rust/coverage scheduler tests: 37 passed; changed hourly workflows passed actionlint; git diff --check passed. Protected hosted checks remain; no bypass used.

@seonghobae
seonghobae force-pushed the fix/opencode-coverage-llvm-tools-v3 branch from ba3b4e7 to 7f5bb2f Compare August 20, 2026 00:51
@seonghobae

Copy link
Copy Markdown
Contributor Author

Rebased Rust coverage image/toolchain fix onto current main@c47bee59. Exact head: 7f5bb2f. Adds pinned system LLVM discovery and explicit LLVM_COV/LLVM_PROFDATA fallback while retaining rustup preview preference and fail-closed missing-tool evidence. Evidence: 68 adjacent OpenCode tests passed; diff check passed. The large hosted actionlint invocation timed out without diagnostics; no local syntax failure was emitted.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@OpenCode Please review exact current head 7f5bb2f against base main@c47bee591c3d95bd305f2130833ed3a4780d2d1d.

Same fix as #1081/#1072: install Debian llvm and export LLVM_COV/
LLVM_PROFDATA so OpenCode coverage-evidence can run cargo-llvm-cov on
Rust repos (e.g. TEPP#46) without rustup llvm-tools-preview.

#1081 concurrency group is held by a non-terminating cancelled model-pool
job; new PR number frees repository_dispatch concurrency.
All required checks green including Strix. Trigger pull_request_target
merge-scheduler path so OpenCode can APPROVE llvm bake for TEPP#46.
@seonghobae
seonghobae force-pushed the fix/opencode-coverage-llvm-tools-v3 branch from 7f5bb2f to cd7d72c Compare August 20, 2026 04:43
@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent review the exact current head $head_oid against protected base 2cce96f. Rebased this hourly caller onto current main; contract tests, changed-workflow actionlint, and diff --check were run on the exact rebased source. The caller keeps explicit target identity, bounded dispatch/retry, OIDC/approved secret scope, and no COPILOT token forwarding. Treat predecessor reviews/checks as historical and do not approve from queued or status-only evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant