test(browser): fail closed on oversized Agent Task observation - #128
Draft
seonghobae wants to merge 4 commits into
Draft
test(browser): fail closed on oversized Agent Task observation#128seonghobae wants to merge 4 commits into
seonghobae wants to merge 4 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28, stacked on unchanged exact PR #105 head
bc1d22d6c4848a173c55fdd18054574299488067.Buyer/security gap
The pinned-Chromium controlled Agent Task measures its semantic-observation JSON byte size but only rejects the impossible zero-length case. Issue #28 requires oversized observation/text to be truncated or fail closed. Without an explicit byte ceiling at the executable browser-evidence boundary, later fixture growth or adapter expansion could silently turn an already bounded role/name snapshot into unbounded evidence.
Dependency
This Draft targets exact #105 head
bc1d22d6c4848a173c55fdd18054574299488067and must remain Draft while #105/#100 and their prerequisites remain active. No prerequisite check, review, status, artifact, coverage, or mergeability result transfers.TDD state
Exact test-only head
71e78784332b2cbe34d3d704b6a03d0d69ff35c2defines the missing executable bound before runner support exists. The intended contract requires:MAX_AGENT_TASK_SEMANTIC_OBSERVATION_BYTESceiling;len(json.dumps(...))path.Production-like runner support is intentionally absent at this head so CI can establish the realistic RED.
Truth boundary
This lane bounds only the controlled semantic-observation evidence emitted by the pinned-browser compatibility runner. It does not define the final product-wide semantic snapshot budget, truncate browser content, authenticate a browser adapter, authorize model context, expose raw HTML, add arbitrary JavaScript, or complete the end-to-end OriginWeave browser adapter. A later production adapter must apply its own reviewed structured-observation bounds at the real observation boundary.