test(browser): measure bounded Chromium process-tree RSS - #73
Draft
seonghobae wants to merge 17 commits into
Draft
test(browser): measure bounded Chromium process-tree RSS#73seonghobae wants to merge 17 commits into
seonghobae wants to merge 17 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28, stacked on exact current PR #72 head
e0b5d43c3a869605aaefa2e4752de7b1b641ddbd.Buyer-visible gap
PR #72 measures the ChromeDriver-reported browser root PID, observation bytes, action latency and task duration, but a single root PID materially undercounts Chromium renderer/GPU/utility descendants. This lane adds one bounded sampled Linux process-tree RSS evidence path for the controlled Agent Task.
Dependency / current stack
Current exact #73 head is
6ba2d03345fa3153230a7d365fba8284696541a1. Fresh compare against exact current #72 heade0b5d43c3a869605aaefa2e4752de7b1b641ddbdreportsbehind_by=0with merge base exactly equal to that prerequisite. Keep Draft while #72/#71/#70/#65 remain active. No prerequisite result transfers.TDD / RCA lineage
Earlier test-first work established bounded
/procprocess-tree discovery, one sampled PID/PPID/RSS snapshot, strict process identity parsing, bounded process-set aggregation, andchromium_process_count/chromium_process_set_rss_bytesevidence.Two concrete defects were then corrected rather than normalized away:
VmRSSremains part of process-tree membership/count but contributes no resident bytes; malformed membership and aggregate overflow remain fail closed; andVmRSSis distinguished from malformed/ambiguous status input, so duplicate, malformed-unit, malformed-shape/value and overflow evidence is rejected rather than converted to absence.The current branch has also been non-destructively aligned to the exact current #72 prerequisite. The implementation tree remains the bounded process-snapshot evidence lane; no prerequisite check/review is reused.
Exact-head proof
On unchanged exact head
6ba2d03345fa3153230a7d365fba8284696541a1against exact current #72 heade0b5d43c3a869605aaefa2e4752de7b1b641ddbd:31550050786: success, including repository contracts, canonical formatting, locked workspace/all-target check, full tests, strict Clippy, rustdoc and exact owned production function/line/region/branch coverage;31550050775: success on the same exact head;No predecessor-head result is transferred.
Truth boundary
This remains controlled Linux CI evidence, not trusted product process-attribution authority. It sums resident RSS only for processes present in one bounded
/proclineage snapshot rooted at the ChromeDriver-issued browser PID. It does not prove per-tab/task ownership, cgroup ownership, CPU, GPU/VRAM, JS heap, cross-platform semantics, or compose a trusted production browser/process adapter. No whole-task RSS claim is permitted until that attribution boundary exists.