feat(policy): classify raw extension proposals as untrusted - #78
Draft
seonghobae wants to merge 3 commits into
Draft
feat(policy): classify raw extension proposals as untrusted#78seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #27, stacked on PR #76.
Buyer/security gap
PR #76 composes exact extension proposal authority with ordinary action policy, but it accepts an already-constructed
ActionRequest. A raw extension-message adapter must not be able to construct that request withInstructionSource::UserorEnterprisePolicymerely because extension transport delivered the message.Dependency
This Draft is stacked on unchanged exact PR #76 head
3d2fff3daa766e5e6d7f25e7727a18e01ff52a2eand must remain Draft while #76/#74 are active.TDD and implementation state
The original test-only head
dbe06efc006fda316201ba295af4b933a4b41f14established the missing raw-message trust boundary. Exact current head3fd7d563d814a895e20d04fc6bd37371e548a875now implementsExtensionMessageActionProposalandevaluate_extension_message_action_proposal.The production boundary:
ProposeTypedActionaccess first;ActionRequestinternally withInstructionSource::WebContent; andExact-head CI run
31477648663completed successfully. No formal reviews or inline review threads are currently returned for this exact head. CodeRabbit explicitly skipped an automated review because the PR remains Draft; that skip is not passing review evidence and is not treated as approval.Truth boundary / remaining #27 work
A separately trusted future adapter may authenticate independent user or managed-policy provenance through a different explicit boundary. This lane does not parse Chromium extension messages, establish transport sender authenticity beyond the existing extension/session/context grant, execute browser input, resolve secrets, verify post-conditions, persist managed-extension policy, or complete the issue #27 compatibility matrix/release gate.
This PR remains Draft until #76/#74 integrate and fresh exact-head/live-base acceptance is re-established. It does not close #27.