feat(evidence): record model disclosure audit metadata - #91
Draft
seonghobae wants to merge 5 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #10, stacked on PR #45.
Buyer/security gap
Protected-main data governance requires credential-free sensitive-access evidence to retain model/provider/region/retention metadata when protected data is disclosed to a model. The current evidence receipt records the sensitive-data decision and handle lifecycle but has no bounded model-route audit metadata, so an operator cannot reconstruct which reviewed model route governed an AI-involved disclosure without relying on external logs.
Dependency
This Draft is stacked on unchanged exact PR #45 head
0f07fea031090c72a448fd9501b49d4dd7568419. That prerequisite owns the shared sensitive-evidence identifier validation surface; this lane must remain Draft while #45 is active.TDD / RCA sequence
ca57239960af4abd09aabc90ddb36c9caefc2798introduced the intended credential-free model-disclosure evidence contract, but CI run31521173221stopped first at canonical rustfmt. That setup failure is not counted as the intended RED.3c4ae22e1f16527b4ad63c9fe58095142e763a25reached the real production boundary. CI run31521597109, Rust contracts job93879681560, passed repository contracts and canonical formatting, thencargo check --locked --workspace --all-targetsfailed with E0432 becauseSensitiveModelDisclosureEvidenceandSensitiveModelDisclosureEvidenceInputdid not exist. This is the valid exact-head RED.b1c8a79660a776e25337c65c598afb4be1e105a9adds the narrow immutable evidence value, andaf8af758a7d4873e2fa28a662f22f9296aeb8fe6exposes it through the evidence crate root.af8af758a7d4873e2fa28a662f22f9296aeb8fe6passed CI run31522004452: Rust contracts job93881137254and Production coverage job93881137057both succeeded, including repository contracts, formatting, locked workspace/all-target check, full tests, strict Clippy, rustdoc, and exact owned production function/line/region/branch coverage.3a33f83af7398038a2581e2e132fabf7183b17afadds only the truthful Unreleased changelog entry and has now passed fresh current-head CI run31522457974. CodeRabbit's exact-head commit status is alsosuccess; GitHub reports the PR mergeable, and no formal reviews or inline review threads are currently returned. No predecessor-head result is promoted as current proof.Implemented contract
SensitiveModelDisclosureEvidenceis an immutable credential-free value object linked to the originating sensitive-datarequest_idanddecision_id. It records only bounded reviewed identifiers for provider, model, processing region, retention policy, training policy, subprocessor policy, and export policy. Every identifier uses the existing sensitive-evidence validation contract; malformed, punctuation-only, whitespace-bearing, slash-bearing, or oversized identifiers fail closed asSensitiveEvidenceError::InvalidIdentifier.The integration regressions exercise every public getter, every identifier position, the shared maximum identifier bound, and the absence of protected-value/provider-credential sentinel material from debug evidence.
Truth boundary
This receipt is audit metadata only. It does not authorize disclosure, authenticate a workload/provider, invoke a model, prove runtime route/region/retention/training/subprocessor/export behavior, carry prompts or outputs, store protected values or provider credentials, implement durable/tamper-evident audit sequencing, or close #10. Runtime/provider enforcement and protected-value disclosure remain separate trusted broker/orchestrator responsibilities.
Keep this PR Draft while #45 remains active. Any prerequisite or current-head movement requires fresh exact-head/live-base validation.