Skip to content

feat(execution): define explicit conversion admission outcomes - #366

Open
seonghobae wants to merge 3 commits into
mainfrom
feat/conversion-admission-contract-main-20260811
Open

feat(execution): define explicit conversion admission outcomes#366
seonghobae wants to merge 3 commits into
mainfrom
feat/conversion-admission-contract-main-20260811

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Objective

Advance issue #312 with the smallest path-disjoint admission contract before changing controller/service acceptance semantics. A future durable admission adapter needs to distinguish a genuinely accepted recoverable job, an idempotent replay of an already accepted canonical job, and a capacity rejection that was never accepted.

Exact test-first evidence

Protected base remains exact main 55d7ae8647208e301f282350f076eeddaba61d11.

  • RED test-only head 762e9427a6e36053431212b0edf7f87d9a971b75: CI run 31446775004, Maven job 93642581394, checked out that exact SHA and failed in testCompile because ConversionAdmissionResult and ConversionAdmissionDecision did not exist.
  • GREEN head 5ac93279c8fbde56bc8497915f89b804bb5b7774: exact-head CI 31446851067, Security Scan 31446851091, SAST Semgrep 31446851157, and fuzz 31446851070 all completed successfully.

The production result makes contradictory authority states unrepresentable: accepted/replayed outcomes carry one canonical job UUID and no retry hint; a capacity rejection carries positive retry guidance and no job UUID.

Scope

New execution-domain value types plus focused tests only. This does not change the current 202 Accepted controller behavior, process-local repository, executor, retry timers, lifecycle model, outbox, worker leases, cancellation, OpenTelemetry, or active PR paths. It does not claim durable acceptance is shipped.

Issue #312 remains open for persistence/outbox/idempotency, worker leasing, backpressure wiring, cancellation and restart/redelivery acceptance.

Merge gate

Ready for ordinary independent review. Merge only if this unchanged exact head continues to satisfy all live required checks, zero valid unresolved findings, current protected base expectations, and the counted approving review from an independent reviewer with write access required by repository policy. Automated checks/comments/model output are evidence, not approval.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8beaaa23-5f8b-4c3e-921f-5bd20da6c662

📥 Commits

Reviewing files that changed from the base of the PR and between 55d7ae8 and 5ac9327.

📒 Files selected for processing (3)
  • src/main/java/com/clearfolio/viewer/execution/ConversionAdmissionDecision.java
  • src/main/java/com/clearfolio/viewer/execution/ConversionAdmissionResult.java
  • src/test/java/com/clearfolio/viewer/execution/ConversionAdmissionResultTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant