Skip to content

feat(execution): define generation-fenced worker lease identity - #367

Open
seonghobae wants to merge 2 commits into
mainfrom
feat/conversion-worker-lease-contract-main-20260811
Open

feat(execution): define generation-fenced worker lease identity#367
seonghobae wants to merge 2 commits into
mainfrom
feat/conversion-worker-lease-contract-main-20260811

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Objective

Advance issue #312 with a second path-disjoint execution primitive: one worker claim must be bound to an exact conversion job, immutable lifecycle generation, and unique lease identity so stale workers cannot authorize publication for a later generation.

Test-first state

This Draft starts intentionally RED at exact test-only head 48d7ca8b3bb2609a5d1a6c8235ec9f309ce0c367. ConversionWorkerLeaseTest requires immutable job/generation/lease authority, exact-triple authorization, and fail-closed issuance for missing identities or non-positive generations. The production type does not exist at this head, so Maven test compilation is expected to fail at that boundary.

Scope

New execution-domain lease value type plus focused tests only. This does not add a durable lease repository, broker, outbox, worker claim transition, stale-worker artifact publication fence, cancellation, backpressure or retry scheduling. It does not modify active lifecycle/repository PR paths and does not claim issue #312 completion.

Acceptance

Observe exact-head RED -> add the smallest immutable production implementation -> exact-head mvn -B --no-transfer-progress verify with zero missed owned production coverage/public Javadocs -> CI/Security Scan/SAST/fuzz -> review/thread/live-base refetch. Keep Draft until GREEN exact-head evidence exists. Later slices must wire this identity into durable worker-claim and publication authority. Independent write-authorized approval remains a separate protected-merge gate.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d01c9e77-7f42-4d03-8b04-0675becc80dd

📥 Commits

Reviewing files that changed from the base of the PR and between 55d7ae8 and 29863b9.

📒 Files selected for processing (2)
  • src/main/java/com/clearfolio/viewer/execution/ConversionWorkerLease.java
  • src/test/java/com/clearfolio/viewer/execution/ConversionWorkerLeaseTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant