feat(durable): define generation-fenced retry schedule record - #369
Open
seonghobae wants to merge 2 commits into
Open
feat(durable): define generation-fenced retry schedule record#369seonghobae wants to merge 2 commits into
seonghobae wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
Changes재시도 레코드
Estimated code review effort: 3 (Moderate) | ~15–30 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
August 11, 2026 00:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Advance issue #312's durable retry requirement with one path-disjoint persisted-schedule primitive. Retry authority must bind an exact job generation and attempt, survive process-local timer loss as serializable state, and become due from its persisted timestamp rather than from an in-memory delayed executor.
Exact test-first evidence
Protected
mainremains exact55d7ae8647208e301f282350f076eeddaba61d11.57f55040a252be20b7a7d5f7691e66b2ace9fd0e: CI run31447392015, Maven job93644429891, exact checkout verified andtestCompilefailed becauseConversionRetryRecorddid not exist.395067aba6d7b15f7944de89a7971d9dd2d55601: exact-head CI31447519266, Security Scan31447519225, SAST Semgrep31447519232, and fuzz31447519228all completed successfully.The production record binds retry identity to one permanently reserved job, positive lifecycle generation, positive attempt number and persisted due time. Due evaluation is inclusive and generation authorization fails closed for another job/generation.
Scope
New durable-domain retry record plus focused tests only. This does not persist the record, replace the current process-local delayed executor, claim a worker lease, dispatch to a broker, implement cancellation, or change HTTP acceptance. It is independent of the active idempotency writer and of the outbox-record lane.
Issue #312 remains open for persisted state/outbox/idempotency, worker lease wiring, durable retry storage/dispatch, backpressure wiring, cancellation, restart/redelivery acceptance, telemetry and integrated release evidence.
Merge gate
Ready for ordinary independent review. Merge only if this unchanged exact head continues to satisfy all live required checks, zero valid unresolved findings, current protected-base expectations, and the counted approving review from an independent reviewer with write access required by repository policy. Automated checks/comments/model output are evidence, not approval.
Summary by CodeRabbit
새로운 기능
테스트