COR-1633: POL-02: wait for blocking rules - #147
Merged
Conversation
There was a problem hiding this comment.
Automated review risk: 4/5.
The polling implementation can bypass blocking rules for unexpected statuses and abort valid scans after a single transient request failure.
Critical or high-priority changes must be addressed.
Automatic approval was not submitted: automated review found critical or high-priority findings.
juangaitanv
reviewed
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--fail, pollcheck_blocking_rulesuntil license evaluation finishes (status != pending), up to 15 minutes, then fail closed.statusdefault tocomplete(one-shot, same as today).corgea lsstays one-shot and does not wait.Test plan
cargo checkstatusdeserialize--fail: no blocking-rules waitstatus): still one-shotRunning without
--failRunning with
--failScanning a different project that doesn't have license violations
Blocking rule disabled
Timeout (status hardcoded to "pending" in doghouse)
Older CLI version unaffected by status