Skip to content

COR-1633: POL-02: wait for blocking rules - #147

Merged
leenk7991 merged 3 commits into
mainfrom
cor-1633-wait-for-blocking-rules
Aug 6, 2026
Merged

COR-1633: POL-02: wait for blocking rules#147
leenk7991 merged 3 commits into
mainfrom
cor-1633-wait-for-blocking-rules

Conversation

@leenk7991

Copy link
Copy Markdown
Member

Summary

  • With --fail, poll check_blocking_rules until license evaluation finishes (status != pending), up to 15 minutes, then fail closed.
  • Older backends that omit status default to complete (one-shot, same as today).
  • corgea ls stays one-shot and does not wait.
  • pairs with https://github.com/Corgea/doghouse/pull/1672

Test plan

  • cargo check
  • unit: missing/pending/complete status deserialize
  • E2E: license blocking rule + forced pending → spinner wait, then exit 0/1 after complete
  • Without --fail: no blocking-rules wait
  • Old doghouse (no status): still one-shot

Running without --fail

Screenshot 2026-08-04 at 5 18 14 PM

Running with --fail

Screenshot 2026-08-04 at 5 18 31 PM

Scanning a different project that doesn't have license violations

Screenshot 2026-08-04 at 5 18 52 PM

Blocking rule disabled

Screenshot 2026-08-04 at 5 23 00 PM

Timeout (status hardcoded to "pending" in doghouse)

Screenshot 2026-08-04 at 5 40 09 PM

Older CLI version unaffected by status

Screenshot 2026-08-04 at 5 41 48 PM

Comment thread src/scanners/blast.rs Outdated
Comment thread src/scanners/blast.rs Outdated

@corgea-security corgea-security left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review risk: 4/5.

The polling implementation can bypass blocking rules for unexpected statuses and abort valid scans after a single transient request failure.

Critical or high-priority changes must be addressed.

Automatic approval was not submitted: automated review found critical or high-priority findings.

@corgea-security corgea-security added the dennis-reviewed Dennis completed an automated review label Aug 4, 2026
Comment thread src/scanners/blast.rs Outdated

@Ibrahimrahhal Ibrahimrahhal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leenk7991
leenk7991 merged commit ee2440b into main Aug 6, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dennis-reviewed Dennis completed an automated review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants