Conversation
Contributor
|
Hi @briri, thanks for the PR. I've just added something now for API v0 because we still use it and it had the same issue. |
gjacob24
reviewed
Aug 3, 2026
| @api_client = User.where(email: token[:client_id]).first | ||
| # Valid if User is active, has permission to use the API and | ||
| # the :client_secret matches the token | ||
| usr = User.where(email: token[:client_id], active: true, api_token: @client_secret).first |
Contributor
There was a problem hiding this comment.
@aaronskiba or @momo3404, could one of you check if this fix for v1 works in your local instance please?
I think it needs to be usr = User.where(email: token[:client_id], active: true).first, without the api_token: @client_secret, but I'm not sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue that allows user's whose account has been deactivated or has had the
use_apipermission revoked to continue using an API v1 JWT. (see slack for a full report of the issue)This PR just adds some checks to the authorization service to ensure the user is still active and has permission when trying to use a JWT.
I'm not sure why rubocop reports a CyclomaticComplexity on here, there is a
rubocop:disableline already in place for that rule.