fix(prelaunch): Phala Cloud script v0.0.16 + v0.0.17 passwd fallback - #113
Merged
Conversation
Guests without chpasswd were falling back to passwd(1) via stdin. Many passwd implementations read /dev/tty during boot and fail with "password for root is unchanged", leaving an empty root password. - empty root password without chpasswd: passwd -l root - DSTACK_ROOT_PASSWORD without chpasswd: only passwd --stdin when supported; otherwise fail clearly - chpasswd path unchanged; random password gen uses head -c Must stay byte-identical to teehouse CURRENT_PRE_LAUNCH_SCRIPT (sha256 93d29be852c0ccf92b275f824d71f1b589e906503c4d67332f36c633412fabe5).
Leechael
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set -ehandling, safer SSH key env cleanup (prior commits on this branch)passwd(1)on guests withoutchpasswdpasswd -l root(same intent as discarded random password)DSTACK_ROOT_PASSWORD: onlypasswd --stdinwhen supported; otherwise fail clearlychpasswdpath unchanged; random password gen useshead -cScript must stay byte-identical to monorepo
teehouse.services.pre_launch_scripts.CURRENT_PRE_LAUNCH_SCRIPT.Version markers for traceback:
Running Phala Cloud Pre-Launch Script v0.0.1793d29be852c0ccf92b275f824d71f1b589e906503c4d67332f36c633412fabe5Test plan
sha256sum phala-cloud-prelaunch-script/prelaunch.shmatches monorepo current hash