Skip to content

fix(vmm): reject conflicting host port mappings - #862

Merged
kvinwang merged 1 commit into
masterfrom
codex/fix-vmm-host-port-conflicts
Aug 3, 2026
Merged

fix(vmm): reject conflicting host port mappings#862
kvinwang merged 1 commit into
masterfrom
codex/fix-vmm-host-port-conflicts

Conversation

@kvinwang

@kvinwang kvinwang commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Problem

Two VM/app definitions could reserve the same host address, port, and protocol because validation considered each mapping in isolation. Both configurations were accepted and the second launch later failed to bind, or traffic reached whichever listener won.

Root cause and fix

Normalize host-port tuples during validation and reject duplicates before persisting or launching the VM.

Implementation

The branch records the following focused implementation work:

  • fix(vmm): reject conflicting host port mappings

Changed paths:

  • dstack/vmm/src/main_service.rs

Scope

This PR addresses one logical vmm finding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.

Dependency and merge order

This PR is based directly on master and does not require another split product PR to merge first.

Verification

  • git diff --check origin/master..origin/codex/fix-vmm-host-port-conflicts: passed.
  • The declared base was verified as an ancestor of the PR head.
  • Focused compile/check verification was run for the changed component where applicable; non-Rust packaging or configuration changes were reviewed against their exact branch delta.

Copilot AI review requested due to automatic review settings July 31, 2026 02:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kvinwang
kvinwang merged commit 28924a1 into master Aug 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants