Skip to content

fix(kms): validate onboarding domains - #863

Merged
kvinwang merged 2 commits into
masterfrom
codex/fix-kms-onboarding-domains
Aug 3, 2026
Merged

fix(kms): validate onboarding domains#863
kvinwang merged 2 commits into
masterfrom
codex/fix-kms-onboarding-domains

Conversation

@kvinwang

@kvinwang kvinwang commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Problem

KMS onboarding accepted DNS/domain values without validating their syntax and expected relationship. Invalid or attacker-controlled names could flow into certificate issuance and service configuration, causing late issuance failures or binding credentials to the wrong name.

Root cause and fix

Validate onboarding domains at the RPC boundary and reject malformed or inconsistent values before any key/certificate state is committed.

Implementation

The branch records the following focused implementation work:

  • fix(kms): validate onboarding domains
  • fix(kms): integrate onboarding domain tests

Changed paths:

  • dstack/kms/src/onboard_service.rs

Scope

This PR addresses one logical kms finding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.

Dependency and merge order

This PR is based directly on master and does not require another split product PR to merge first.

Verification

  • git diff --check origin/master..origin/codex/fix-kms-onboarding-domains: passed.
  • The declared base was verified as an ancestor of the PR head.
  • Focused compile/check verification was run for the changed component where applicable; non-Rust packaging or configuration changes were reviewed against their exact branch delta.

Copilot AI review requested due to automatic review settings July 31, 2026 02:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kvinwang
kvinwang merged commit f39396e into master Aug 3, 2026
21 checks passed
kvinwang added a commit that referenced this pull request Aug 3, 2026
[STACKED on #863] fix(kms): make Bootstrap one-time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants