fix(guest-agent): report the effective quote prefix - #864
Merged
Conversation
Defect: TdxQuote always reported app-data even when the request selected a custom report-data prefix. Observed symptom: the response metadata disagreed with the domain separation actually used to construct report_data. Fix: derive the returned prefix from the effective QuoteContentType and cover default and custom prefixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The guest-agent response reported the configured quote prefix rather than the effective prefix actually used after defaults/normalization. Clients could then call the advertised endpoint and fail because it differed from the active route.
Root cause and fix
Return the resolved effective quote prefix from runtime configuration, including the defaulted value.
Implementation
The branch records the following focused implementation work:
fix(guest-agent): report effective quote prefixChanged paths:
dstack/guest-agent/src/rpc_service.rsScope
This PR addresses one logical
guest-agentfinding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.Dependency and merge order
This PR is based directly on
masterand does not require another split product PR to merge first.Verification
git diff --check origin/master..origin/codex/fix-guest-agent-quote-prefix: passed.